🤖 Sync from open-cluster-management-io/config-policy-controller: #96 #397
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
Previously, when the controller is removed, it could leave a mess behind in the form of ConfigurationPolicy objects with finalizers on them. That would also result in the CRD being stuck. Now, the controller will put a finalizer on its own deployment when at least one ConfigurationPolicy has a finalizer. Also, while the deployment is being deleted, the finalizers on ConfigurationPolicies will be removed immediately, in the same way they would be when the CRD was being deleted. Note: in this implementation, related objects might *never* be pruned when the controller is removed. Since the controller deployment is in a different namespace than the ConfigutaionPolicies it watches, the controller's cache cannot be limited to a single namespace the way it was before. Instead, this uses additional cache selectors to limit watches on ConfigurationPolicies and Deployments to the relevant namespaces. Refs: - https://issues.redhat.com/browse/ACM-2923 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit e60e939)
|
Kudos, SonarCloud Quality Gate passed! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| needDeploymentFinalizer := false | ||
|
|
||
| for _, plc := range policiesList.Items { | ||
| if objHasFinalizer(&plc, pruneObjectFinalizer) { |
Check warning
Code scanning / SonarCloud
<!--SONAR_ISSUE_KEY:AYXQ0_DzteWHWF4GPkzC-->Implicit memory aliasing in for loop. <p>See more on <a href="https://sonarcloud.io/project/issues?id=open-cluster-management_config-policy-controller&issues=AYXQ0_DzteWHWF4GPkzC&open=AYXQ0_DzteWHWF4GPkzC&pullRequest=397">SonarCloud</a></p>
|
@JustinKuli , the gosec error is fixed here (needs a review): The flakiness of the Framework test should be fixed by this: |
There was a problem hiding this comment.
Let's merge this one and then let the Magic Mirror sync the Gosec fix:
open-cluster-management-io/config-policy-controller#97
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: magic-mirror-bot[bot], mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-2.7 |
|
@JustinKuli: new pull request created: #400 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
Closes #398