🤖 Sync from open-cluster-management-io/config-policy-controller: #100 #412
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
When a hosted cluster is removed from OCM, it triggers the hosted cluster instance of the config-policy-controller to be uninstalled on the hosting cluster. If any ConfigurationPolicy uses pruneObjectBehavior, they will have finalizers set on them. During an uninstall, the finalizers are immediately removed on the next evaluation of the ConfigurationPolicy with pruneObjectBehavior set so that the uninstall can proceed immediately. The issue is if the ConfigurationPolicy sets evaluationInterval to a long value, the finalizer won't be removed until the next evaluation time, which could be hours. This is not an issue when it's not deployed in hosted mode because the CRD is also deleted at the same time, which causes the ConfigurationPolicy to have a deletionTimestamp which then causes immediate evaluation for the finalizer to be removed. Relates: https://issues.redhat.com/browse/ACM-3233 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit eb8f720)
Without this commit, as soon as a SIGINT signal was received, mgr.Start would exit and cause the main function to finish before PeriodicallyExecConfigPolicies could finish the removal of finalizers when the config-policy-controller is being uninstalled. Co-authored-by: Justin Kulikauskas <jkulikau@redhat.com> Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 82a7f86)
|
There is a flaky test that is fixed here: I'll retry the flaky test until this merges so that I can wait for a review on the flaky test fix on Monday. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: magic-mirror-bot[bot], mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
|
/cherry-pick release-2.7 |
|
@mprahl: new pull request created: #415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
Closes #413