🤖 Sync from open-cluster-management-io/config-policy-controller: #128 #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
This is another situation where the kube api server may omit "empty" values in some of the default kubernetes objects. This commit also refactors the test code for re-use. Refs: - https://issues.redhat.com/browse/ACM-5132 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 5bace4e)
Creating a configuration policy that "belongs" to a parent policy is slightly tricky, because it needs an owner reference with a UID. A common function makes this a bit easier. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 0036ade)
Similar to some other fixes we had for empty bools, strings, and ints. Refs: - https://issues.redhat.com/browse/ACM-5132 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit fd913d8)
It was tricky to find an example of this. Most optional structs I found would get populated with some default values, meaning they wouldn't be omitted by the kube api. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit dff741d)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs: