Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/config-policy-controller: #136 #555

Merged
merged 1 commit into from
Aug 9, 2023
Merged

🤖 Sync from open-cluster-management-io/config-policy-controller: #136 #555

merged 1 commit into from
Aug 9, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@gparvin
Log policy NonCompliance
85b656d 
Consistently log the policy noncompliance and compliance as updates are
made. The goal is to allow tools that scrape logs to be able to obtain
the violation message and the details on when compliance changes happen.

Refs:
 - https://issues.redhat.com/browse/ACM-5568

Signed-off-by: Gus Parvin <gparvin@redhat.com>
(cherry picked from commit 73f50ce)
@openshift-ci
Copy link

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit 2bc1b59 into main Aug 9, 2023
10 of 12 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1691587202274 branch August 9, 2023 13:48
@gparvin
Copy link
Contributor

gparvin commented Sep 5, 2023

/cherry-pick release-2.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2023
Merged
@openshift-cherrypick-robot
Copy link

@gparvin: new pull request created: #574

In response to this:

/cherry-pick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gparvin @openshift-cherrypick-robot