-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Sync from open-cluster-management-io/config-policy-controller: #158 #556
Conversation
Previously, these settings were not being applied to the config used in 'hosted mode'. This commit also includes a typo fix, and adjusts some settings used by the tests. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 2078334)
/cherry-pick release-2.8 |
@JustinKuli: once the present PR merges, I will cherry-pick it on top of release-2.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Previously, the evaluation interval could prevent policies from being applied on new namespaces when they appeared. Now, a new controller watches namespaces on the target cluster, and can signal to the config policy controller when a policy's selected namespaces have changed, so that it can be re-evaluated. A new controller-manager is used in hosted mode, in order to create a cache for the namespaces on the target cluster. This change required some setup adjustments in order to start both managers in this case. Refs: - https://issues.redhat.com/browse/ACM-6428 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 7e64817)
643772e
to
1c70dff
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli, magic-mirror-bot[bot], mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
@JustinKuli: #556 failed to apply on top of branch "release-2.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
Closes #557