🤖 Sync from open-cluster-management-io/config-policy-controller: #161 #575
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
Previously, the template would always be marked as compliant after the resource it defines was created. But if the object definition included a `status`, then the object might not actually match what was desired. Now, in this case, the template will be marked as non-compliant. Refs: - https://issues.redhat.com/browse/ACM-7020 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 04a91c0)
The `object` and `unstruct` fields were not self-explanatory. Now they are `existingObj` and `desiredObj` respectively. This will help readers understand why they are used the way they are. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 4eea290)
In both instances, the object is already assured to be non-nil, so there are no errors that can occur here. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 05177fb)
By keeping track of which branch we're in, it became obvious that the `generateSingleObjReason` calls were actually just static lookups. So that function has been removed. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit f6f82b5)
Putting this in the function itself means that the function could be called from multiple places, and the metrics would still be recorded. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 406ccf7)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
|
/cherry-pick release-2.9 |
|
@JustinKuli: new pull request created: #613 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs: