Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhtap dockerfile with allowed image references #607

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add rhtap dockerfile with allowed image references #607

merged 1 commit into from
Oct 25, 2023

Conversation

gparvin
Copy link
Contributor

@gparvin gparvin commented Oct 23, 2023

See the details in the associated task.

Refs:

See the details in the associated task.

Refs:
 - https://issues.redhat.com/browse/ACM-7178

Signed-off-by: Gus Parvin <gparvin@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gparvin
Copy link
Contributor Author

gparvin commented Oct 25, 2023

/cc @dhaiducek

@openshift-ci openshift-ci bot requested a review from dhaiducek October 25, 2023 13:21
Copy link
Contributor

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the effect of having go mod vendor in there, but it seems that's how they want it! Thanks for working this one out, @gparvin!

@openshift-ci
Copy link

openshift-ci bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f06d19d into stolostron:main Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants