Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] 🤖 Sync from open-cluster-management-io/config-policy-controller: #177, #178 #652

Commits on Nov 27, 2023

  1. Fix a bug related to unnamed objects

    In the case where an object-template included an unnamed object and only
    one object was returned, it went into the typical `handleSingleObj` flow
    but marked `exists` as true without setting `existingObj` in the input
    to `handleSingleObj`. There was an assumption that `existingObj` would
    always be set if `exists` was set.
    
    Commit ffc115c made this panic because `GetUID` was being called on a
    nil `existingObj`. Prior to this, it seems it would just erroneously say
    it was compliant without checking it.
    
    Relates:
    https://issues.redhat.com/browse/ACM-8731
    
    Signed-off-by: mprahl <mprahl@users.noreply.github.com>
    (cherry picked from commit a901475)
    mprahl authored and openshift-cherrypick-robot committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    eb0e4d4 View commit details
    Browse the repository at this point in the history