Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/config-policy-controller: #230, #231 #823

Closed
wants to merge 4 commits into from
Closed

🤖 Sync from open-cluster-management-io/config-policy-controller: #230, #231 #823

wants to merge 4 commits into from

Commits on Apr 24, 2024

  1. Improve OperatorGroup removal logic 

    In some clusters, a default OperatorGroup might be provided in a
namespace for "global" operators. This OperatorGroup was not being
correctly identified by the policy: in fact any pre-existing group that
did not match the group specified by the policy, or the one that would
be generated when the policy does not specify a group, was not reported
correctly.

Now, pre-existing "special" operator groups should be reported and
handled correctly. If they are owned by another resource, they will be
considered as "used" for the purposes of the DeleteIfUnused setting.

This also removes the "regular" `Delete` option for OperatorGroups: that
was too likely to cause confusion.

Refs:
 - https://issues.redhat.com/browse/ACM-11022
 - https://issues.redhat.com/browse/ACM-11077

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 21143ac)
    @JustinKuli
    JustinKuli authored and Magic Mirror committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    739f1cc View commit details
    Browse the repository at this point in the history

  2. Make the operator policy message case consistent 

    Relates:
https://issues.redhat.com/browse/ACM-11026

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit 6790eff)
    @mprahl
    mprahl authored and Magic Mirror committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e96a201 View commit details
    Browse the repository at this point in the history

  3. Remove commas from operator policy messages 

    This is to make it easier to delineate between each message section in
the policy compliance message.

Relates:
https://issues.redhat.com/browse/ACM-11026

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit 5fdf739)
    @mprahl
    mprahl authored and Magic Mirror committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7c30133 View commit details
    Browse the repository at this point in the history

  4. Include the CSV name in compliance messages 

    Relates:
https://issues.redhat.com/browse/ACM-11026

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit 8206ac6)
    @mprahl
    mprahl authored and Magic Mirror committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9f22d3e View commit details
    Browse the repository at this point in the history