-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ACM 13003 Fast cluster page load #3866
base: main
Are you sure you want to change the base?
ACM 13003 Fast cluster page load #3866
Conversation
Signed-off-by: John Swanke <jswanke@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeswanke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test unit-tests-sonarcloud |
/test unit-tests-sonarcloud |
…-13003-Fast-cluster-page-load Signed-off-by: John Swanke <jswanke@redhat.com>
…-13003-Fast-cluster-page-load Signed-off-by: John Swanke <jswanke@redhat.com>
Quality Gate failedFailed conditions |
…-13003-Fast-cluster-page-load Signed-off-by: John Swanke <jswanke@redhat.com>
Quality Gate failedFailed conditions |
@jeswanke: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jeswanke I'm getting an error when I run this using |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hey Kevin-- so this is the other half of the pr you said was huge:
a. organizes the events so that cluster and policy data is sent first from the backend
b. removes loaded state from LoadPluginData.tsx so that LoadingPage doesn't appear
c. allows the ClusterPage to gradually load rather then wait for everything to load, similar to large AWS lists
So effectively we still use the loaded state, but now further down at the individual page level:
https://localhost:3000/multicloud/infrastructure/clusters/details/local-cluster/local-cluster/overview
The reason for doing this is:
I'm think we don't need cluster table pagination until we reach 7k clusters
Signed-off-by: John Swanke jswanke@redhat.com