Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM 13003 Fast cluster page load #3866

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jeswanke
Copy link
Contributor

@jeswanke jeswanke commented Sep 16, 2024

hey Kevin-- so this is the other half of the pr you said was huge:

  1. the first half is now ACM-14157 which is the non-visible caching changes
  2. this half is the one that:
    a. organizes the events so that cluster and policy data is sent first from the backend
    b. removes loaded state from LoadPluginData.tsx so that LoadingPage doesn't appear
    c. allows the ClusterPage to gradually load rather then wait for everything to load, similar to large AWS lists

So effectively we still use the loaded state, but now further down at the individual page level:

  1. in AcmEmptyState.tsx we check if the loaded state is set and if not, we show the LoadingPage because the data might not be loaded yet so we don't know yet if there's none to show
  2. in ErrorPage.tsx -- we don't show an error until the backend is loaded in case of the issue you uncovered with this showing Not found at first-- now it will show LoadingPage until backend has loaded
    https://localhost:3000/multicloud/infrastructure/clusters/details/local-cluster/local-cluster/overview

The reason for doing this is:

  1. There's no reason to wait until everything is loaded to see the Applications list since it doesn't depend on it
  2. By prioritizing cluster/policy those tables can load faster and user can immediately see progresss

I'm think we don't need cluster table pagination until we reach 7k clusters

Signed-off-by: John Swanke jswanke@redhat.com

Signed-off-by: John Swanke <jswanke@redhat.com>
Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: John Swanke <jswanke@redhat.com>
@jeswanke
Copy link
Contributor Author

/test unit-tests-sonarcloud

Signed-off-by: John Swanke <jswanke@redhat.com>
@jeswanke
Copy link
Contributor Author

/test unit-tests-sonarcloud

…-13003-Fast-cluster-page-load

Signed-off-by: John Swanke <jswanke@redhat.com>
…-13003-Fast-cluster-page-load

Signed-off-by: John Swanke <jswanke@redhat.com>
Copy link

sonarcloud bot commented Sep 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Signed-off-by: John Swanke <jswanke@redhat.com>
…-13003-Fast-cluster-page-load

Signed-off-by: John Swanke <jswanke@redhat.com>
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
46.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Nov 11, 2024

@jeswanke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud 56c7231 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@KevinFCormier
Copy link
Contributor

@jeswanke I'm getting an error when I run this using npm run plugins. Can you take a look, pease?
image

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants