Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-14254 Openshift Virtulization Credentials support #3888

Conversation

vishsanghishetty
Copy link
Contributor

@vishsanghishetty vishsanghishetty commented Sep 23, 2024

Description

This PR is for ticket

Acceptance Criteria

  • Adds External infrastructure support to OpenShift Virtualization Credential
  • Adds Unit tests

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
KevinFCormier

This comment was marked as outdated.

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
…tructure

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishsanghishetty
Once this PR has been reviewed and has the lgtm label, please ask for approval from kevinfcormier. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
@vishsanghishetty

This comment was marked as outdated.

@vishsanghishetty vishsanghishetty changed the title ACM-14254 Openshift Virtulization Credentials support ACM-14254 Openshift Virtulization Credentials support - Part 1 Sep 27, 2024
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Copy link

sonarcloud bot commented Oct 30, 2024

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
@vishsanghishetty vishsanghishetty force-pushed the ACM-14254-openshift-virtulization-credentials branch from 3520a1e to 0305a5d Compare November 1, 2024 15:37
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
@vishsanghishetty vishsanghishetty force-pushed the ACM-14254-openshift-virtulization-credentials branch from 2d67ecf to 47e51f4 Compare November 1, 2024 18:22
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
@vishsanghishetty
Copy link
Contributor Author

/retest

Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
Signed-off-by: vsanghishetty <vishali.kamenani@ymail.com>
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Nov 4, 2024

@vishsanghishetty: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 15b34fa link true /test check
ci/prow/unit-tests-sonarcloud 15b34fa link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vishsanghishetty vishsanghishetty marked this pull request as draft November 4, 2024 19:49
@vishsanghishetty vishsanghishetty deleted the ACM-14254-openshift-virtulization-credentials branch November 5, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants