ACM-13648 - distribution version comparison (AcmTable advanced search iteration 2) #3902
Conversation
Randy424
force-pushed
the
ACM-13648-distribution-ver-comparison
branch
from
bf93571
to
1b02179
Compare
Randy424
force-pushed
the
ACM-13648-distribution-ver-comparison
branch
3 times, most recently
from
428b955
to
e938a3a
Compare
| onMouseEnter={() => { | ||
| const newIsHoveredArray = { ...isHovered } | ||
| newIsHoveredArray[index] = true | ||
| setIsHovered(newIsHoveredArray) | ||
| }} | ||
| onMouseLeave={() => { | ||
| const newIsHoveredArray = { ...isHovered } | ||
| newIsHoveredArray[index] = false | ||
| setIsHovered(newIsHoveredArray) | ||
| }} |
There was a problem hiding this comment.
Is the best way to handle this (they are helping me render the tooltip onMouseHover) to use a window listener?
Sonar is describes my method here as using a non-native interactive element.
There was a problem hiding this comment.
I think there's a simpler solution. Will this accomplish what you need?
<Tooltip
content={t('Select a column name to choose an operator')}
trigger={!constraint.columnId ? 'mouseenter' : 'manual'}
position="bottom"
>
|
/hold Still need to refactor this bit |
Randy424
force-pushed
the
ACM-13648-distribution-ver-comparison
branch
2 times, most recently
from
c9a53ad
to
49a5f95
Compare
Signed-off-by: Randy Bruno Piverger <rbrunopi@redhat.com>
Randy424
force-pushed
the
ACM-13648-distribution-ver-comparison
branch
from
49a5f95
to
218b077
Compare
|
Update: added change for nullish coalescing operator code smell. |
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinFCormier, Randy424 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
Regarding: https://issues.redhat.com/browse/ACM-13648
Now supports distribution version.
Before:
After:
