Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][DEPLOY] Unable to install the multi-cluster engine using the provided installation script #242

Open
rhmdnd opened this issue Mar 30, 2022 · 5 comments · May be fixed by #243
Open
Assignees
Labels
bug Something isn't working deploy specific to this repository... does not imply product specific issues

Comments

@rhmdnd
Copy link

rhmdnd commented Mar 30, 2022

Describe the bug
It appears that the deploy process for the multi-cluster engine expects a file that doesn't exist. I followed the directions in the README.md

To Reproduce
Steps to reproduce the behavior:

  1. Log into the cluster using oc login and token obtained from the console
  2. Run ./start.sh
  3. Provide 2.0-latest as the SNAPSHOT TAG
  4. The installation fails because of a missing file

Expected behavior
I'd expect the multi-cluster operator to be installed.

Screenshots

$ ./start.sh
* Testing connection
* Using baseDomain: router-default.lbragstad-dev.devcluster.openshift.com
* oc CLI Client Version: 4.10.6
Find snapshot tags @ https://quay.io/stolostron/cmb-custom-registry?tab=tags
Enter SNAPSHOT TAG:
2.0-latest
SNAPSHOT_CHOICE is set to 2.0-latest
Error: stat catalogsources/multicluster-engine.yaml: no such file or directory

Desktop (please complete the following information):

  • OS: [e.g. mac, rhel, etc..] Fedora 35
  • Browser [e.g. chrome, safari, firefox] Firefox 98.0 (98.0-3.fc35)
  • Snapshot [e.g. SNAPSHOT-XX-XX-XX-XX] 2.0-latest
@rhmdnd rhmdnd added bug Something isn't working deploy specific to this repository... does not imply product specific issues labels Mar 30, 2022
@rhmdnd
Copy link
Author

rhmdnd commented Mar 30, 2022

Perhaps this script was moved and the reference to the catalogsources wasn't updated:

https://github.com/stolostron/deploy/tree/master/catalogsources

rhmdnd added a commit to rhmdnd/deploy that referenced this issue Mar 30, 2022
This installation script must have been shuffled around from the root of
the repository since it contained relative paths to files and
directories available from the repository root. Following the directions
in the multiclusterengine/ directory results in a failed deploy because
the script assumes those relative paths.

This commit updates the script so that it installs cleanly by updating
the relative paths.

Closes stolostron#242
@zkayyali812
Copy link
Contributor

@rhmdnd
Do you have the prereqs defined here installed as well - https://github.com/stolostron/deploy#lets-get-started?
Notably I think yq 4.12+ is required.

If I recall correctly I've seen this bug happen with some versions of yq. Notably I am using yq 4.16 on my environment and it is working as expected here.

@rhmdnd
Copy link
Author

rhmdnd commented Mar 31, 2022

Hi @zkayyali812

I'm using yq 4.24.2:

$ yq -V
yq (https://github.com/mikefarah/yq/) version 4.24.2

@zkayyali812
Copy link
Contributor

Did you install yq with snap by any chance?
mikefarah/yq#463
If installed by snap it uses strict confinement which may be an issue here.

@rhmdnd
Copy link
Author

rhmdnd commented Mar 31, 2022

I installed the binary directly using the following:

VERSION='v4.24.2'
BINARY='yq_linux_amd64'
sudo wget https://github.com/mikefarah/yq/releases/download/${VERSION}/${BINARY} -O /usr/bin/yq && sudo chmod +x /usr/bin/yq

rhmdnd added a commit to rhmdnd/deploy that referenced this issue Jun 13, 2022
This installation script must have been shuffled around from the root of
the repository since it contained relative paths to files and
directories available from the repository root. Following the directions
in the multiclusterengine/ directory results in a failed deploy because
the script assumes those relative paths.

This commit updates the script so that it installs cleanly by updating
the relative paths.

Closes stolostron#242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deploy specific to this repository... does not imply product specific issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants