Add constructor for pre-existing DynamicWatcher #111
Conversation
|
/hold I believe this is ready for review, but I want to run and end-to-end kind of thing with it before it potentially merges. |
| @@ -269,6 +271,32 @@ func NewResolverWithCaching( | |||
| return resolver, channel, err | |||
| } | |||
|
|
|||
| // NewResolverWithDynamicWatcher creates a new caching TemplateResolver instance, using the provided dependency-watcher. | |||
There was a problem hiding this comment.
Could you please document that batch management is disabled?
This allows users that already have a DynamicWatcher and are using Query Batches to supply their instance to the template resolver. Most details of managing the watcher and the batch are delegated to the user: this package will not automatically stop the query batch after the template is resolved, for instance. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
pre-existing-dynamic-client
branch
2 times, most recently
from
f7526fe to
ed92bd3
Compare
|
|
open-cluster-management-io/config-policy-controller#235 is an example use of this (also using another change to this package which I think would be a good separate PR). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
This allows users that already have a DynamicWatcher and are using Query Batches to supply their instance to the template resolver. Most details of managing the watcher and the batch are delegated to the user: this package will not automatically stop the query batch after the template is resolved, for instance.