Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2.12 hub template features to template-resolver #149

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Sep 11, 2024

See each commit for more details.

…me is set

Relates:
https://issues.redhat.com/browse/ACM-12560

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Relates:
https://issues.redhat.com/browse/ACM-13612

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d5e0066 into stolostron:main Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants