Update kubernetes-dependency-watches to v0.10.0 #158
Conversation
go.mod
Outdated
|
|
||
| // This can be removed when upgrading to v0.32.0. This replace is to include this fix: | ||
| // https://github.com/kubernetes/client-go/commit/2176e80333ddd9966b37758f8417bf72ceb61d5f | ||
| replace k8s.io/client-go => k8s.io/client-go v0.0.0-20240815135022-d63a65fbe7d4 |
There was a problem hiding this comment.
Rather than replace, can you just get the commit and see what happens?
go get k8s.io/client-go@d63a65fbe7d4
There was a problem hiding this comment.
I updated the SHA--not sure why the SHA is different in the GitHub link and the Go pseudo-version. I guess something about the K8s release process?
There was a problem hiding this comment.
@dhaiducek it didn't work on kubernetes-dependency-watches because the master branch for client-go doesn't share a parent commit with a tagged version so it just comes up as a 0.0.0 version and that messes up other dependencies that need client-go.
I think it'll be the same here. We actually don't need the replace here but could just put the replace on the propagator, but I thought it'd be clearer if it was done everywhere.
There was a problem hiding this comment.
Oh, I see. That mirroring thing Kubernetes has going on makes things odd.
There was a problem hiding this comment.
I've come to discover that replaces are somewhat annoying because they're more difficult to maintain and break go install. So with this, there won't be a way to go install the template-resolver outside of the cloning the repo. Good thing we have the policy-cli on its way. 🙂
There was a problem hiding this comment.
Okay, let me remove that replace then. I'll just replace it in the Propagator.
This is required for using client-go v0.31+ and controller-runtime v0.19+. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
update-client-go2
branch
from
aa5bbee
to
41d87de
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is required for using client-go v0.31+ and controller-runtime v0.19+.