Make the autoindent regex stricter #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the edge case where a user has autoindent in the key of
a map. For example:
data:
autoindent-test: '{{ "hello\nworld" | autoindent }}'
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
ckandag
approved these changes
Sep 22, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckandag, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mprahl
added a commit
to mprahl/governance-policy-propagator
that referenced
this pull request
Sep 22, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
added a commit
to mprahl/config-policy-controller
that referenced
this pull request
Sep 22, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
added a commit
to mprahl/governance-policy-propagator
that referenced
this pull request
Sep 22, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
openshift-merge-robot
pushed a commit
to stolostron/governance-policy-propagator
that referenced
this pull request
Sep 22, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
openshift-merge-robot
pushed a commit
to stolostron/config-policy-controller
that referenced
this pull request
Sep 22, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
JustinKuli
pushed a commit
to JustinKuli/governance-policy-propagator-1
that referenced
this pull request
Nov 5, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
dhaiducek
pushed a commit
to dhaiducek/governance-policy-propagator-1
that referenced
this pull request
Dec 14, 2021
This is to include the fix from: stolostron/go-template-utils#18 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the edge case where a user has autoindent in the key of
a map. For example: