add kind to pending status

Signed-off-by: Will Kutler <wkutler@redhat.com>
stolostron · Nov 10, 2022 · ae22618 · ae22618
1 parent 79715ac
commit ae22618
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/templatesync/template_sync.go b/controllers/templatesync/template_sync.go
@@ -379,7 +379,7 @@ func (r *PolicyReconciler) Reconcile(ctx context.Context, request reconcile.Requ
 			errMsg := fmt.Sprintf("Dependencies were not satisfied: %s", pendingErr)
 
 			r.emitTemplatePending(instance, tIndex, tName, errMsg)
-			tLogger.Info("Dependencies were not satisfied in the policy template",
+			tLogger.Info("Dependencies were not satisfied for the policy template",
 				"namespace", instance.GetNamespace(),
 				"kind", gvk.Kind,
 			)
@@ -553,7 +553,7 @@ func (r *PolicyReconciler) processDependencies(ctx context.Context, dClient dyna
 func generatePendingErr(dependencyFailures []depclient.ObjectIdentifier) error {
 	names := make([]string, len(dependencyFailures))
 	for i, dep := range dependencyFailures {
-		names[i] = dep.Name
+		names[i] = fmt.Sprintf("%s %s", dep.Kind, dep.Name)
 	}
 
 	nameStr := strings.Join(names, ", ")

diff --git a/test/e2e/case12_ordering_test.go b/test/e2e/case12_ordering_test.go
@@ -40,7 +40,7 @@ func generateEventOnPolicy(plcName string, cfgPlcNamespacedName string, eventTyp
 		msg)
 }
 
-var _ = Describe("Test status sync", Ordered, func() {
+var _ = Describe("Test dependency logic in template sync", Ordered, func() {
 	AfterEach(func() {
 		opt := metav1.ListOptions{}
 		utils.ListWithTimeout(clientHubDynamic, gvrPolicy, opt, 0, true, defaultTimeoutSeconds)