Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/governance-policy-framework-addon: #90 #188

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

magic-mirror-bot[bot]
Copy link

The template name duplications could be an issue with users managing
lots of templates and there being a requirement no names can conflict.
To avoid having duplicate names there would need to be additional fields
in the status which I don't want to add unless we have a customer RFE.
This update removes a previous change.

Refs:
 - https://issues.redhat.com/browse/ACM-7265
 - https://issues.redhat.com/browse/ACM-7566

Signed-off-by: Gus Parvin <gparvin@redhat.com>
(cherry picked from commit 3045540)
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign gparvin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit b0c50a1 into main Oct 10, 2023
14 of 15 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1696958052363 branch October 10, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant