Add test for configpolicy cleanup during uninstall #541
Conversation
|
Skipping CI for Draft Pull Request. |
Tests that the ConfigurationPolicy CRD does not become stuck due to pruneObjectBehavior finalizers when the controller is uninstalled. Refs: - https://issues.redhat.com/browse/ACM-2923 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
configpol-uninstall-cleanup
branch
from
bb53bee
to
e7fc1ba
Compare
JustinKuli
force-pushed
the
configpol-uninstall-cleanup
branch
2 times, most recently
from
953fcb8
to
277f7e0
Compare
When a selector is given, `kubectl logs` will only get 10 lines. Now it will get all the logs for the container. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
configpol-uninstall-cleanup
branch
from
277f7e0
to
89ea08f
Compare
JustinKuli
requested review from
mprahl and
dhaiducek
and removed request for
mprahl
|
The tests here should fail until open-cluster-management-io/config-policy-controller#96 is merged into stolostron. But this previous run shows it passing with a dev image: https://github.com/stolostron/governance-policy-framework/actions/runs/3969435606/jobs/6803925704, so I think it's ready for initial review at least. |
Now it targets the correct namespace, and puts some extra info into the ginkgo writer, which will be printed if the spec fails. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tests that the ConfigurationPolicy CRD does not become stuck due to pruneObjectBehavior finalizers when the controller is uninstalled.
Refs:
Signed-off-by: Justin Kulikauskas jkulikau@redhat.com