Test ManagedClusterLabels in hub templates #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test is added to the BVT, one is SVT-only. I was planning on having an additional test to check that if a label is queried that doesn't exist, then the policy would be non-compliant (I thought that such an error would appear as a template-error), but the Go stdlib `template` inserts `<no value>` in that situation. That might not be ideal, but it's not something to fix at this moment. Refs: - https://issues.redhat.com/browse/ACM-4177 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
mprahl
approved these changes
Apr 6, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This test really hates me |
|
The prune test should be more stable after this fix: I need to file a follow-up Jira to make the code around handling status update failures more robust in general when pruneObjectBehavior is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test is added to the BVT, one is SVT-only. I was planning on having an additional test to check that if a label is queried that doesn't exist, then the policy would be non-compliant (I thought that such an error would appear as a template-error), but the Go stdlib
templateinserts<no value>in that situation. That might not be ideal, but it's not something to fix at this moment.Refs: