Handle the operator policy message changes #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
changed the title
JustinKuli
previously approved these changes
Apr 25, 2024
|
/hold for WIP status |
It's WIP since I didn't test it locally, so I'm letting CI validate it 😆 |
Specifically, the CSV name is now listed in the message. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
|
This is blocked by open-cluster-management-io/config-policy-controller#234. |
|
/retest |
|
/unhold |
mprahl
changed the title
|
@JustinKuli this is ready for review now |
JustinKuli
approved these changes
Apr 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dhaiducek
reviewed
Apr 26, 2024
| @@ -822,12 +832,7 @@ var _ = Describe("GRC: [P1][Sev1][policy-grc] Test the compliance history API", | |||
|
|
|||
| event0 := events[0].(map[string]interface{}) | |||
There was a problem hiding this comment.
Is this guaranteed to have something in it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, the CSV name is now listed in the message.