Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Cluster monitoring label #1254

Merged
merged 3 commits into from
Oct 18, 2023
Merged

add Cluster monitoring label #1254

merged 3 commits into from
Oct 18, 2023

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Oct 12, 2023 •
edited
Loading

  • set {{openshift.io/cluster-monitoring=true }}label on open-cluster-management-observability namespaces
  • Moved the predicate functions to a new file
  • Added test cases for Predicate functions

https://issues.redhat.com/browse/ACM-7631

@coleenquadros
Copy link
Contributor Author

/retest-required

@coleenquadros
Copy link
Contributor Author

coleenquadros commented Oct 13, 2023 •
edited
Loading

@subbarao-meduri Tested by deleting the label and the controller reconciles to add it back again
Screenshot 2023-10-13 at 16 15 24

saswatamcode
saswatamcode approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Generally lgtm, just a few small nits.

operators/multiclusterobservability/pkg/config/config.go Show resolved Hide resolved
...robservability/controllers/multiclusterobservability/multiclusterobservability_controller.go Outdated Show resolved Hide resolved
...robservability/controllers/multiclusterobservability/multiclusterobservability_controller.go Outdated Show resolved Hide resolved
@saswatamcode
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Oct 16, 2023
@coleenquadros
Copy link
Contributor Author

/test e2e-kind

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, saswatamcode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros
Copy link
Contributor Author

/retest

@subbarao-meduri
Copy link
Collaborator

/test e2e-kind

@coleenquadros
Copy link
Contributor Author

/test test-unit

@coleenquadros
add cluster monitoring label to mco namespace
54e026b 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
add watch for namespace
4f9bd76 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
add controller reference for namespace
68b4840 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

43.0% 43.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023 •
edited
Loading

@coleenquadros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 68b4840 link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@subbarao-meduri subbarao-meduri merged commit 45b4ec9 into stolostron:main Oct 18, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@subbarao-meduri subbarao-meduri Awaiting requested review from subbarao-meduri

Assignees

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coleenquadros @saswatamcode @subbarao-meduri @openshift-merge-robot