Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACM-11093]: apply security context for microshift #1422

Merged
merged 2 commits into from
May 15, 2024
Merged

[ACM-11093]: apply security context for microshift #1422

merged 2 commits into from
May 15, 2024
+44 −12

Conversation

thibaultmg
Copy link
Contributor

No description provided.

@thibaultmg
apply security restrictions
7800ef0 
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
@thibaultmg
add privileged
fbef69c 
Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

saswatamcode
saswatamcode approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 15, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saswatamcode, thibaultmg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 15, 2024

@thibaultmg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e fbef69c link unknown /test test-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@thibaultmg thibaultmg merged commit 501d88a into stolostron:main May 15, 2024
13 of 15 checks passed
@thibaultmg thibaultmg deleted the ACM_11093 branch May 15, 2024 14:04
coleenquadros pushed a commit to coleenquadros/multicluster-observability-operator that referenced this pull request May 23, 2024
@thibaultmg @coleenquadros
[ACM-11093]: apply security context for microshift (stolostron#1422)
7632583 
* apply security restrictions

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>

* add privileged

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>

---------

Signed-off-by: Thibault Mange <22740367+thibaultmg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees

@saswatamcode saswatamcode

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibaultmg @saswatamcode