Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for BVT testing #1598

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Fix tests for BVT testing #1598

merged 7 commits into from
Sep 4, 2024

Conversation

coleenquadros
Copy link
Contributor

@coleenquadros coleenquadros commented Sep 3, 2024 •
edited
Loading

The BVT tests are reporting failure because some of the managed clusters are never properly imported. However, Obs tests are also not correctly detecting and skipping these unhealthy clusters, and expecting Obs add-on to be present.

https://app.travis-ci.com/github/stolostron/canary/jobs/625626340

@coleenquadros coleenquadros changed the title update tests to ignore clusters that dont have observability addon in… Ignore clusters that dont have observability addon iinstalled Sep 3, 2024
@coleenquadros coleenquadros changed the title Ignore clusters that dont have observability addon iinstalled Fix tests for BVT testing Sep 3, 2024
philipgough
philipgough approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 3, 2024
@coleenquadros
Copy link
Contributor Author

/retest

subbarao-meduri
subbarao-meduri approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@subbarao-meduri subbarao-meduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@coleenquadros
Copy link
Contributor Author

/retest

5 similar comments
@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/retest

@coleenquadros
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot removed the lgtm label Sep 4, 2024
@coleenquadros
Copy link
Contributor Author

/test test-e2e

@coleenquadros
update tests to ignore clusters that dont have observability addon in…
581abc6 
…stalled

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
update tests to ignore clusters that dont have observability addon in…
b88b9e0 
…stalled

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
force add on obervability label for kind
ff5cbc9 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
add logs to tests
f7ea6e1 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
update
af05af6 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
update
ed31c48 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@coleenquadros
update
290ee5a 
Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@coleenquadros coleenquadros enabled auto-merge (squash) September 4, 2024 11:43
subbarao-meduri
subbarao-meduri approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@subbarao-meduri subbarao-meduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coleenquadros, philipgough, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [coleenquadros,philipgough,subbarao-meduri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 40d69e8 into stolostron:main Sep 4, 2024
22 checks passed
@coleenquadros
Copy link
Contributor Author

/cherry-pick 2.11

@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: cannot checkout 2.11: error checking out "2.11": exit status 1 error: pathspec '2.11' did not match any file(s) known to git

In response to this:

/cherry-pick 2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coleenquadros
Copy link
Contributor Author

/cherry-pick release-2.11

@coleenquadros
Copy link
Contributor Author

/cherry-pick release-2.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 4, 2024
Open
@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: new pull request created: #1600

In response to this:

/cherry-pick release-2.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coleenquadros
Copy link
Contributor Author

/cherry-pick release-2.9

@coleenquadros
Copy link
Contributor Author

/cherry-pick release-2.8

@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: new pull request created: #1601

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 4, 2024
Open
@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: new pull request created: #1602

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 4, 2024
Open
@openshift-cherrypick-robot
Copy link
Collaborator

@coleenquadros: #1598 failed to apply on top of branch "release-2.8":

Applying: update tests to ignore clusters that dont have observability addon installed
Applying: update tests to ignore clusters that dont have observability addon installed
Applying: force add on obervability label for kind
Using index info to reconstruct a base tree...
M	cicd-scripts/setup-e2e-tests.sh
Falling back to patching base and 3-way merge...
Auto-merging cicd-scripts/setup-e2e-tests.sh
CONFLICT (content): Merge conflict in cicd-scripts/setup-e2e-tests.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 force add on obervability label for kind
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

JoaoBraveCoding pushed a commit to JoaoBraveCoding/multicluster-observability-operator that referenced this pull request Sep 9, 2024
@coleenquadros @JoaoBraveCoding
Fix tests for BVT testing (stolostron#1598)
6f9a0d2 
* update tests to ignore clusters that dont have observability addon installed

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update tests to ignore clusters that dont have observability addon installed

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* force add on obervability label for kind

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* add logs to tests

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

---------

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
JoaoBraveCoding pushed a commit to JoaoBraveCoding/multicluster-observability-operator that referenced this pull request Sep 9, 2024
@coleenquadros @JoaoBraveCoding
Fix tests for BVT testing (stolostron#1598)
d36d83f 
* update tests to ignore clusters that dont have observability addon installed

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update tests to ignore clusters that dont have observability addon installed

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* force add on obervability label for kind

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* add logs to tests

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

* update

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>

---------

Signed-off-by: Coleen Iona Quadros <coleen.quadros27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

@subbarao-meduri subbarao-meduri subbarao-meduri approved these changes

Assignees

@subbarao-meduri subbarao-meduri

@philipgough philipgough

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coleenquadros @openshift-cherrypick-robot @subbarao-meduri @philipgough