Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Historical Analysis in Alert Analysis dash #1615

Conversation

jacobbaungard
Copy link
Contributor

With this commit, the Historical Analysis row is expanded by default in the Alert Analysis Grafana dashboard. This matches the default behaviour in other dashboards.

Just moving the collapsed: true -> collapsed: false caused some issues with the panels showing in this row. As a result I manually made the change in Grafana and exported the result. As a result, there are a few other changes caused by this in the dashboard yaml here.

With this commit, the `Historical Analysis` row is expanded by default in
the `Alert Analysis` Grafana dashboard. This matches the default
behaviour in other dashboards.

Just moving the `collapsed: true` -> `collapsed: false` caused some
issues with the panels showing in this row. As a result I manually made
the change in Grafana and exported the result. As a result, there are a
few other changes caused by this in the dashboard yaml here.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Copy link

openshift-ci bot commented Sep 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jacobbaungard
Copy link
Contributor Author

/test all

@jacobbaungard jacobbaungard marked this pull request as ready for review September 11, 2024 12:49
Copy link

sonarcloud bot commented Sep 11, 2024

@jacobbaungard
Copy link
Contributor Author

/retest

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,philipgough]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 63ce20e into stolostron:main Sep 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants