Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable non-applicable Grafana features #1624

Conversation

jacobbaungard
Copy link
Contributor

Disables:

  • Correlations (the page anyway just comes up with "Please contact your administrator to create new correlations.")
  • Public Dashboards (users anyway doesn't have permissions for that)

Disables:
- Correlations
- Public Dashboards (users anyway doesn't have permissions for that)

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Collaborator

@subbarao-meduri subbarao-meduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Sep 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobbaungard, philipgough, subbarao-meduri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobbaungard,philipgough,subbarao-meduri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jacobbaungard
Copy link
Contributor Author

/retest

1 similar comment
@jacobbaungard
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 54cdb1c into stolostron:main Sep 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants