-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce sharedInformer memory usage #1316
Reduce sharedInformer memory usage #1316
Conversation
/retest |
3a97d83
to
4c871a2
Compare
/retest |
open-cluster-management-io/api#320 updates the OCM informers. |
Trim ManagedFields to reduce shared informer memory usage. This requires informers generated with newer version of k8s/client-go [0.29] so currently it is done for following informers: - k8s - submarinerconfig Rest informers should be updated once WithTransform() is available. Refer: kubernetes/kubernetes#118455 Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>
4c871a2
to
fb30e71
Compare
Cool. I updated the code to use it. |
64ba6de
to
fd9e59f
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tpantelis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
...and use the new WithTransform function on the informers to trim the managed fields. Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
fd9e59f
to
5398787
Compare
Quality Gate failedFailed conditions |
@tpantelis We need to override the sonarcheck for this. |
/override ci/prow/sonarcloud |
@tpantelis: Overrode contexts on behalf of tpantelis: ci/prow/sonarcloud In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
Trim ManagedFields to reduce shared informer memory usage. This requires informers generated with newer version of k8s/client-go [0.29] so currently it is done for following informers:
- k8s
- submarinerconfig
Rest informers should be updated once WithTransform() is available.
Refer: kubernetes/kubernetes#118455
DependsOn #1318