Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: standardize the code with cargo clippy #37

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mateolafalce
Copy link

Hello!
I see in the #36 a proposal for standarizartion of the code with clippy. I found it a good idea so I think that to maintain standardization it would be convenient to add continuous integration to this new requirement into the build.yml file

@mateolafalce
Copy link
Author

In addition, I fix:

error: redundant redefinition of a binding `method`
  --> src/contract/nft/item_contract.rs:48:13
   |
48 |             let method = method;
   |             ^^^^^^^^^^^^^^^^^^^^
   |
help: `method` is initially defined here
  --> src/contract/nft/item_contract.rs:42:13
   |
42 |         let method = NftItemContractMethods::GetNftData.into();
   |             ^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals

@SlavikBaranov
Copy link
Contributor

Hey @mateolafalce I agree, we should definitely use clippy. I've already mentioned in #36 that we'll incorporate these changes in 0.13 and enable it in CI right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants