Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality function #583

Closed
lujiashun opened this issue Sep 27, 2022 · 0 comments · Fixed by #585
Closed

feature(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality function #583

lujiashun opened this issue Sep 27, 2022 · 0 comments · Fixed by #585
Assignees
@lujiashun
Labels
A-feature feature with good idea

Comments

@lujiashun
Copy link

lujiashun commented Sep 27, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

function ConditionNumberFromMultipleEquality in the file storage/tianmu/core/query.cpp

  List_STL_Iterator<Item_field> ifield;
  List_STL_Iterator<Item_field> li;
  li = conds->get_fields().begin();

the logic is correct, but code can be cleaner.
Reference:mysql/mysql-server@908666c

Describe the solution you'd like

improve the function‘s readability；
remove ”stonedb8“ comments；
Describe alternatives you've considered

Additional context
@lujiashun lujiashun added the A-feature feature with good idea label Sep 27, 2022
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 27, 2022
feat(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality funct…
4830eae 
…ion. (stoneatom#583)

[summary]
1 improve the function's readability;
2 remove "stonedb8" comments;
@lujiashun lujiashun mentioned this issue Sep 27, 2022
Merged
15 tasks
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 27, 2022
feat(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality funct…
2d31133 
…ion. (stoneatom#583)

[summary]
1 improve the function's readability;
2 remove "stonedb8" comments;
mergify bot pushed a commit that referenced this issue Sep 27, 2022
@mergify
feat(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality funct…
e2721a8 
…ion. (#583)

[summary]
1 improve the function's readability;
2 remove "stonedb8" comments;
@lujiashun lujiashun self-assigned this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lujiashun lujiashun

Labels
A-feature feature with good idea
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(StoneDB 8.0): refactor ConditionNumberFromMultipleEquality function. (#583) lujiashun/stonedb
1 participant
@lujiashun