Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(StoneDB 8.0): 'bool partitioned' parameter is added by MySQL 8.0 in handlerton->create function #596

Closed
DandreChen opened this issue Sep 28, 2022 · 1 comment
Assignees
Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0

Comments

@DandreChen
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

handlerton->create function function add "bool partitioned" parameter, in tianmu as below:

handler *rcbase_create_handler(handlerton *hton, TABLE_SHARE *table, bool partitioned, MEM_ROOT *mem_root) 

Describe the solution you'd like

adapt the code for MySQL 8.0

Describe alternatives you've considered

Additional context

@DandreChen DandreChen added the A-feature feature with good idea label Sep 28, 2022
@hustjieke hustjieke added this to the stonedb_8.0_v1.0.0 milestone Sep 28, 2022
@hustjieke hustjieke moved this to In Progress in StoneDB for MySQL 8.0 Sep 28, 2022
@DandreChen DandreChen added the C-stonedb-8.0 associated with stonedb 8.0 label Sep 28, 2022
@DandreChen DandreChen assigned lujiashun and unassigned DandreChen Sep 29, 2022
@lujiashun
Copy link

From the create functions of storage engines as below, we can see that the partitioned value is only used by innodb, others ignore the partitioned argument.
innodb is row_based, and support partition feature to split rows into partitions;
tianmu is column_based, now unsupport partition feature. Maybe we can support it in some day,eg, split rows in partitions,
and columns of row belongs to different partitions should not be stored together in one DPN,etc.

innobase storage

static handler *innobase_create_handler(handlerton *hton, TABLE_SHARE *table,
                                        bool partitioned, MEM_ROOT *mem_root) {
  if (partitioned) {
    ha_innopart *file = new (mem_root) ha_innopart(hton, table);
    if (file && file->init_partitioning(mem_root)) {
      destroy(file);
      return (nullptr);
    }
    return (file);
  }

  return (new (mem_root) ha_innobase(hton, table));
}

myisam storage

static handler *myisam_create_handler(handlerton *hton, TABLE_SHARE *table,
                                      bool, MEM_ROOT *mem_root) {
  return new (mem_root) ha_myisam(hton, table);
}

archive storage

static handler *archive_create_handler(handlerton *hton, TABLE_SHARE *table,
                                       bool, MEM_ROOT *mem_root) {
  return new (mem_root) ha_archive(hton, table);
}

blackhole storage

static handler *blackhole_create_handler(handlerton *hton, TABLE_SHARE *table,
                                         bool, MEM_ROOT *mem_root) {
  return new (mem_root) ha_blackhole(hton, table);
}

federated storage

static handler *federated_create_handler(handlerton *hton, TABLE_SHARE *table,
                                         bool, MEM_ROOT *mem_root) {
  return new (mem_root) ha_federated(hton, table);
}

heap storage

static handler *heap_create_handler(handlerton *hton, TABLE_SHARE *table, bool,
                                    MEM_ROOT *mem_root) {
  return new (mem_root) ha_heap(hton, table);
}

myisammrg storage

static handler *myisammrg_create_handler(handlerton *hton, TABLE_SHARE *table,
                                         bool, MEM_ROOT *mem_root) {
  return new (mem_root) ha_myisammrg(hton, table);
}

tina storage

static handler *tina_create_handler(handlerton *hton, TABLE_SHARE *table, bool,
                                    MEM_ROOT *mem_root) {
  return new (mem_root) ha_tina(hton, table);
}

lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 29, 2022
… in handlerton->create function. (stoneatom#596)

[summary]
1 add 'bool m_partioned' in tianmu engine's handler to indicate the parameter;
lujiashun pushed a commit to lujiashun/stonedb that referenced this issue Sep 29, 2022
… in handlerton->create function. (stoneatom#596)

[summary]
1  Add 'bool m_partioned' in tianmu engine's handler to indicate the parameter;
mergify bot pushed a commit that referenced this issue Sep 29, 2022
… in handlerton->create function. (#596)

[summary]
1  Add 'bool m_partioned' in tianmu engine's handler to indicate the parameter;
Repository owner moved this from In Progress to Done in StoneDB for MySQL 8.0 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-feature feature with good idea C-stonedb-8.0 associated with stonedb 8.0
Projects
Development

No branches or pull requests

3 participants