Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(tianmu): group_concat.test has in-consistent behavior in CICD and prompt mode #834

Closed
3 tasks done
RingsC opened this issue Oct 27, 2022 · 1 comment
Closed
3 tasks done
Assignees
Labels
A-bug Something isn't working prio: high High priority

Comments

@RingsC
Copy link
Contributor

RingsC commented Oct 27, 2022

Have you read the Contributing Guidelines on issues?

Please confirm if bug report does NOT exists already ?

  • I confirm there is no existing issue for this

Describe the problem

Using MTR to run group_concat.test, it's failed, but the test passed via mysql.

Expected behavior

Pass the MTR test.

How To Reproduce

MTR mode:
1: Run ./mtr --suite=tianmu group_concat.
2: test failed

MySQL mode
1: Start the mysql server.
2: Login to mysql and run the group_concat script mannually.
3: Gets the right output.

Environment

Linux/Windows/etc.

Are you interested in submitting a PR to solve the problem?

  • Yes, I will!
@RingsC RingsC added the A-bug Something isn't working label Oct 27, 2022
@RingsC RingsC self-assigned this Oct 27, 2022
@RingsC RingsC added the prio: high High priority label Oct 27, 2022
@RingsC
Copy link
Contributor Author

RingsC commented Oct 27, 2022

The root cause:
1: when we run MTR, the name of group_concate(name, '') is parsed as Item_blob according to Text type. But, when we run the test mannualy, it is parsed as Item_string.

2: Therefore, in Engine::Convert(int &is_null, String *value, types::RCDataType &rcitem, enum_field_types f_type), we cannot process MYSQL_TYPE_LONG_BLOB properly.

mergify bot pushed a commit that referenced this issue Oct 29, 2022
… prompt mode (#834)

To enable  group concat function for support `text` type, and enable some MTR test for
this function.
@RingsC RingsC closed this as completed Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bug Something isn't working prio: high High priority
Projects
None yet
Development

No branches or pull requests

1 participant