Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): ALTER TABLE prompt information is incorrect.(#1142) #1183

Merged
merged 2 commits into from
Jan 5, 2023

Conversation

DandreChen
Copy link
Collaborator

Summary about this PR

Issue Number: close #1142

[summary]
1.Add test cases for ALTER TABLE when exception occurs by inplace algorithm
2.Print the specific information of known exceptions to better understand the cause of the problem

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Jan 3, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Base: 43.29% // Head: 42.94% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (bf52ffb) compared to base (f88fde8).
Patch coverage: 88.88% of modified lines in pull request are covered.

❗ Current head bf52ffb differs from pull request most recent head 6594ec1. Consider uploading reports for the commit 6594ec1 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1183      +/-   ##
===================================================
- Coverage            43.29%   42.94%   -0.36%     
===================================================
  Files                 1830     1830              
  Lines               396110   396031      -79     
===================================================
- Hits                171506   170062    -1444     
- Misses              224604   225969    +1365     
Impacted Files Coverage Δ
storage/tianmu/handler/ha_tianmu.cpp 57.36% <50.00%> (+0.31%) ⬆️
storage/tianmu/core/tianmu_table.cpp 49.14% <100.00%> (-0.01%) ⬇️
storage/tianmu/core/dimension_group_virtual.h 0.00% <0.00%> (-65.12%) ⬇️
storage/tianmu/core/dimension_group_virtual.cpp 0.00% <0.00%> (-44.80%) ⬇️
storage/tianmu/compress/dictionary.cpp 12.74% <0.00%> (-42.24%) ⬇️
storage/tianmu/core/aggregator_advanced.h 3.22% <0.00%> (-37.64%) ⬇️
storage/tianmu/compress/top_bit_dict.cpp 26.81% <0.00%> (-34.73%) ⬇️
storage/tianmu/compress/range_code.h 45.81% <0.00%> (-25.82%) ⬇️
storage/tianmu/compress/data_stream.h 38.70% <0.00%> (-24.20%) ⬇️
storage/tianmu/compress/arith_coder.cpp 14.76% <0.00%> (-16.46%) ⬇️
... and 96 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RingsC
Copy link
Contributor

RingsC commented Jan 5, 2023

Nice, LGTM

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…oneatom#1142)

Add test cases for ALTER TABLE when exception occurs by inplace algorithm
)

Print the specific information of known exceptions to better understand the cause of the problem
@mergify mergify bot merged commit 3f04748 into stoneatom:stonedb-5.7-dev Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ALTER TABLE prompt information is incorrect
3 participants