fix(load): fix mysqld crash when loaded data column contains double enclosed char. (#1263) #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
lujiashun
requested review from
RingsC,
hustjieke,
haitaoguan,
isredstar and
wisehead
lujiashun
changed the title
wisehead
reviewed
Feb 2, 2023
| ++ptr; | ||
| } | ||
| } else if (size == 2) { | ||
| --search_end; | ||
| while (ptr < search_end && (*ptr != *c_pattern || ptr[1] != c_pattern[1])) { | ||
| if (escape_char_ && *ptr == escape_char_) | ||
| ptr += 2; | ||
| else | ||
| else if (string_qualifier_ && *ptr == string_qualifier_ && ptr + 1 < search_end && |
There was a problem hiding this comment.
this piece of code is repeated 4 times, how about add a new function for it?
(string_qualifier_ && *ptr == string_qualifier_ && ptr + 1 < search_end &&
*(ptr + 1) == string_qualifier_)
lujiashun
force-pushed
the
fix-1263-stonedb5.7
branch
from
509db0a to
0423e1a
Compare
Codecov ReportBase: 43.28% // Head: 43.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1268 +/- ##
===================================================
+ Coverage 43.28% 43.31% +0.02%
===================================================
Files 1830 1830
Lines 396156 396171 +15
===================================================
+ Hits 171483 171606 +123
+ Misses 224673 224565 -108
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
lujiashun
force-pushed
the
fix-1263-stonedb5.7
branch
from
0423e1a to
da4a8eb
Compare
RingsC
reviewed
Feb 3, 2023
| @@ -0,0 +1,2 @@ | |||
| "765893","37","27","44221","2021-06-28 02:01:16","计算售罄率出错：ORA-04036: PGA memory used by the instance exceeds PGA_AGGREGATE_LIMITORA-06512: at ""BOSNDS3.O2O_STORESALERATE_SET"", line 49 | |||
There was a problem hiding this comment.
what will happens? """ xxx """, and """" xxxx """"
There was a problem hiding this comment.
add these test case . Please check the MTR result file or datafile(issue1263-2.txt and issue1263-3.txt).
- double enclosed char will be interpred as a normal char;
- singe enclosed char before field-terminated string will be interpred as enclose char
- sing enclosed char with non-filed-termniated string will be interpreted as a normal char;
lujiashun
force-pushed
the
fix-1263-stonedb5.7
branch
2 times, most recently
from
87af55d to
8ddcfb3
Compare
…r. (stoneatom#1263) [summary] 1. crash reason is the loader column number each time is not 65535 but report 65535; occurs when using limit clause or duplicate key; 2. support double enclosed char, ref:https://dev.mysql.com/doc/refman/5.7/en/load-data.html
lujiashun
force-pushed
the
fix-1263-stonedb5.7
branch
from
8ddcfb3 to
b08ae17
Compare
wisehead
approved these changes
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
Issue Number: close #1263
occurs when using limit clause or duplicate key;
Tests Check List
Changelog
Documentation