Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(mtr): optimize func_sec_to_time.test(#1196) #1298

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

davidshiz
Copy link
Collaborator

Summary about this PR

Issue Number: ref #1196

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Feb 14, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 43.28% // Head: 43.13% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (8d5a68c) compared to base (07a3d72).
Patch coverage: 43.75% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1298      +/-   ##
===================================================
- Coverage            43.28%   43.13%   -0.16%     
===================================================
  Files                 1830     1830              
  Lines               396156   396260     +104     
===================================================
- Hits                171483   170930     -553     
- Misses              224673   225330     +657     
Impacted Files Coverage Δ
storage/tianmu/core/aggregation_algorithm.h 60.00% <ø> (+22.50%) ⬆️
storage/tianmu/core/engine.cpp 54.14% <0.00%> (ø)
storage/tianmu/core/pack_guardian.h 100.00% <ø> (ø)
storage/tianmu/core/temp_table.cpp 71.71% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 55.55% <ø> (+0.09%) ⬆️
storage/tianmu/loader/load_parser.cpp 69.91% <ø> (+6.19%) ⬆️
storage/tianmu/system/configuration.cpp 100.00% <ø> (ø)
storage/tianmu/system/configuration.h 0.00% <ø> (-100.00%) ⬇️
storage/tianmu/core/aggregation_algorithm.cpp 55.78% <21.42%> (-17.06%) ⬇️
storage/tianmu/core/pack_guardian.cpp 42.75% <42.75%> (-25.77%) ⬇️
... and 90 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit fd5c85f into stoneatom:stonedb-5.7-dev Feb 14, 2023
Copy link
Contributor

@shangyanwen shangyanwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@davidshiz davidshiz deleted the mtr branch February 15, 2023 08:31
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants