Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu):add some feature of init auto_increment_value for tianmu(#1201, #1072, #1059) #1315

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

isredstar
Copy link
Collaborator

@isredstar isredstar commented Feb 16, 2023

Summary about this PR

Issue Number: close #1201 , #1072 , #1059

  1. add create table ... auto_increment=...
  2. add alter table ... auto_increment=...
  3. add show create table can display auto_increment=...
  4. add update tablename set auto_increment_col=value, when value> auto_increment_value,the next auto increment would be value

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 0.00% // Head: 43.11% // Increases project coverage by +43.11% 🎉

Coverage data is based on head (a3b78d9) compared to base (a1d0ad2).
Patch coverage: 49.05% of modified lines in pull request are covered.

❗ Current head a3b78d9 differs from pull request most recent head 816c430. Consider uploading reports for the commit 816c430 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1315       +/-   ##
====================================================
+ Coverage                 0   43.11%   +43.11%     
====================================================
  Files                    0     1830     +1830     
  Lines                    0   396363   +396363     
====================================================
+ Hits                     0   170907   +170907     
- Misses                   0   225456   +225456     
Impacted Files Coverage Δ
storage/tianmu/core/engine.cpp 54.35% <0.00%> (ø)
storage/tianmu/core/engine.h 30.43% <ø> (ø)
storage/tianmu/core/filter.cpp 54.31% <ø> (ø)
storage/tianmu/core/tianmu_table.h 90.90% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 55.83% <40.00%> (ø)
storage/tianmu/core/tianmu_attr.cpp 72.27% <85.71%> (ø)
storage/tianmu/core/table_share.cpp 87.50% <100.00%> (ø)
storage/tianmu/core/tianmu_attr.h 75.82% <100.00%> (ø)
storage/tianmu/core/tianmu_table.cpp 49.54% <100.00%> (ø)
sql/xa.cc 30.09% <0.00%> (ø)
... and 1829 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@isredstar isredstar self-assigned this Feb 17, 2023
@isredstar isredstar added this to the stonedb_5.7_v1.0.3 milestone Feb 17, 2023
Copy link

@lujiashun lujiashun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit dc2c64b into stoneatom:stonedb-5.7-dev Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: When show the table structure,it will support keyword display "AUTO INCREMENT".
3 participants