Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tianmu):DDL function filtering optimization is not supported(#1325) #1330

Merged
merged 2 commits into from
Feb 28, 2023
Merged

feat(tianmu):DDL function filtering optimization is not supported(#1325) #1330

merged 2 commits into from
Feb 28, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Feb 23, 2023 •
edited
Loading

Modify points:

  1. Fix the error of judgment logic
  2. Fix the value problem of (sql_mode) in the slave thread

Summary about this PR

Issue Number: close #1325

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Feb 23, 2023
@konghaiya konghaiya force-pushed the dev_lhj_1325 branch 2 times, most recently from ea4802e to 7b83951 Compare February 23, 2023 13:09
@konghaiya
feat(tianmu):DDL function filtering optimization is not supported(sto…
ed1fd71 
…neatom#1325)

Modify points:
1. Fix the error of judgment logic
2. Fix the value problem of (sql_mode) in the slave thread
@konghaiya konghaiya self-assigned this Feb 24, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.3 milestone Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Base: 43.12% // Head: 43.12% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f96f848) compared to base (0f42505).
Patch coverage: 92.30% of modified lines in pull request are covered.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1330      +/-   ##
===================================================
- Coverage            43.12%   43.12%   -0.01%     
===================================================
  Files                 1830     1830              
  Lines               396385   396395      +10     
===================================================
- Hits                170946   170944       -2     
- Misses              225439   225451      +12
Impacted Files Coverage Δ
sql/sql_table.cc 65.21% <88.88%> (+<0.01%) ⬆️
sql/auth/sql_authorization.cc 20.87% <100.00%> (+0.06%) ⬆️
sql/sql_trigger.cc 81.05% <100.00%> (+0.20%) ⬆️
storage/tianmu/handler/ha_tianmu.cpp 56.03% <100.00%> (+0.07%) ⬆️
storage/innobase/include/dict0stats_bg.ic 50.00% <0.00%> (-50.00%) ⬇️
storage/innobase/include/ut0mutex.ic 71.42% <0.00%> (-23.81%) ⬇️
storage/innobase/row/row0umod.cc 62.50% <0.00%> (-4.17%) ⬇️
mysys/my_write.c 34.48% <0.00%> (-3.45%) ⬇️
storage/innobase/dict/dict0stats_bg.cc 91.48% <0.00%> (-2.13%) ⬇️
storage/myisam/mi_dynrec.c 57.47% <0.00%> (-1.36%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

hustjieke
hustjieke suggested changes Feb 27, 2023
View reviewed changes
sql/auth/sql_authorization.cc Outdated Show resolved Hide resolved
sql/sql_table.cc Outdated Show resolved Hide resolved
sql/sql_table.cc Outdated Show resolved Hide resolved
sql/sql_table.cc Outdated Show resolved Hide resolved
sql/sql_trigger.cc Outdated Show resolved Hide resolved
storage/tianmu/handler/ha_tianmu.cpp Outdated Show resolved Hide resolved
duanfuxiang0
duanfuxiang0 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hustjieke
hustjieke approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f8df638 into stoneatom:stonedb-5.7-dev Feb 28, 2023
@konghaiya konghaiya deleted the dev_lhj_1325 branch March 27, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wisehead wisehead wisehead approved these changes

@hustjieke hustjieke hustjieke approved these changes

@duanfuxiang0 duanfuxiang0 duanfuxiang0 approved these changes

@RingsC RingsC Awaiting requested review from RingsC

Assignees

@konghaiya konghaiya

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.3
4 participants
@konghaiya @wisehead @hustjieke @duanfuxiang0