Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(Docs/website): update description on data type content #1366 #1338

Merged
merged 3 commits into from
Mar 2, 2023
Merged

docs(Docs/website): update description on data type content #1366 #1338

merged 3 commits into from
Mar 2, 2023

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Feb 28, 2023 •
edited
Loading

Summary about this PR

Issue Number: close #1366

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@hustjieke hustjieke marked this pull request as ready for review February 28, 2023 07:40
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-docs docs for pull request label Feb 28, 2023
@hustjieke
Copy link
Collaborator Author

ping @RingsC @haitaoguan @wisehead PTAR.

@hustjieke hustjieke force-pushed the feat_update_docs_on_unsigned_data_types_issue1366 branch from 52ac1a0 to bea2cd3 Compare February 28, 2023 08:33
@Nliver Nliver self-requested a review February 28, 2023 09:11
@Nliver Nliver added this to the stonedb_5.7_v1.0.3 milestone Feb 28, 2023
Nliver
Nliver approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@Nliver Nliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit b911192 into stoneatom:stonedb-5.7-dev Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nliver Nliver Nliver approved these changes

@RingsC RingsC RingsC approved these changes

@haitaoguan haitaoguan Awaiting requested review from haitaoguan

@wisehead wisehead Awaiting requested review from wisehead

Assignees

@hustjieke hustjieke

Labels
PR-docs docs for pull request
Projects
StoneDB for MySQL 5.7
Status: Done
Milestone
StoneDB_5.7_v1.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@hustjieke @RingsC @Nliver