Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu): add_timestamp_column Query result is incorrect #1327 #1341

Conversation

wisehead
Copy link
Collaborator

@wisehead wisehead commented Feb 28, 2023

Summary about this PR

Issue Number: close #issue_number_you_created

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Feb 28, 2023
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (f8df638) 43.11% compared to head (4df80a9) 43.16%.

❗ Current head 4df80a9 differs from pull request most recent head 5292c9c. Consider uploading reports for the commit 5292c9c to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1341      +/-   ##
===================================================
+ Coverage            43.11%   43.16%   +0.04%     
===================================================
  Files                 1830     1830              
  Lines               396395   396395              
===================================================
+ Hits                170915   171093     +178     
+ Misses              225480   225302     -178     
Impacted Files Coverage Δ
storage/tianmu/handler/ha_tianmu.cpp 56.03% <100.00%> (ø)
storage/innobase/buf/buf0buddy.cc 33.76% <0.00%> (-2.60%) ⬇️
storage/innobase/log/log0log.cc 77.77% <0.00%> (ø)
storage/innobase/page/page0zip.cc 69.27% <0.00%> (+0.08%) ⬆️
sql/sql_planner.cc 69.97% <0.00%> (+0.09%) ⬆️
storage/innobase/handler/ha_innodb.cc 64.80% <0.00%> (+0.12%) ⬆️
storage/innobase/trx/trx0purge.cc 65.82% <0.00%> (+0.16%) ⬆️
storage/innobase/fil/fil0fil.cc 66.25% <0.00%> (+0.19%) ⬆️
sql/partitioning/partition_handler.cc 67.99% <0.00%> (+0.20%) ⬆️
sql/field.h 49.11% <0.00%> (+0.22%) ⬆️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@duanfuxiang0 duanfuxiang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit cf31f0a into stoneatom:stonedb-5.7-dev Mar 6, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants