fix(core): rm incorrect boundary check on rough check with between #1344 #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oneatom#1344 [summary] 1. change file(tianmu_attr_exeq_rs.cpp) format from dos 2 unix 2. rm incorrect between check, actually the v1 or v2 equal to boundary is illegal and it will cause empty result when condition like `where col = PLUS_INF_64`, `where col = PLUS_INF_DBL`, `where col = MINUS_INF_DBL`: ``` common::RoughSetValue TianmuAttr::RoughCheckBetween(int pack, int64_t v1, int64_ // and then consider negation bool is_float = Type().IsFloat(); auto const &dpn(get_dpn(pack)); - if (!is_float && (v1 == common::PLUS_INF_64 || v2 == common::MINUS_INF_64)) { - res = common::RoughSetValue::RS_NONE; - } else if (is_float && (v1 == *(int64_t *)&common::PLUS_INF_DBL || v2 == *(int64_t *)&common::MINUS_INF_DBL)) { - res = common::RoughSetValue::RS_NONE; - } else if (!is_float && (v1 > dpn.max_i || v2 < dpn.min_i)) { + if (!is_float && (v1 > dpn.max_i || v2 < dpn.min_i)) { ```
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1357 +/- ##
================================================
Coverage 43.15% 43.16%
================================================
Files 1830 1830
Lines 396431 396429 -2
================================================
+ Hits 171066 171102 +36
+ Misses 225365 225327 -38
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
wisehead
reviewed
Mar 8, 2023
| else | ||
| span = (span / (npack - trivial_packs)) / double(GetMaxInt64() - GetMinInt64()); | ||
| } | ||
| if (auto sp = GetFilter_Hist(); sp && GetPackType() == common::PackType::INT) { |
There was a problem hiding this comment.
the diff tool doesn't work, it's not clear what code changes are made?
There was a problem hiding this comment.
talked with @hustjieke , the code looks good.
wisehead
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary about this PR
change file(tianmu_attr_exeq_rs.cpp) format from dos 2 unix
rm incorrect between check, actually the v1 or v2 equal to boundary is illegal and it will cause empty result when condition like
where col = PLUS_INF_64,where col = PLUS_INF_DBL,where col = MINUS_INF_DBL:Issue Number: close #1344
Tests Check List
Changelog
Documentation