Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): integer column with primary key problem(#1363) #1370

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Mar 8, 2023

Cause of the problem:
It is caused by writing back the field value when inserting the primary key and the problem of the assignment interface used.

Summary about this PR

Issue Number: close #1362
Issue Number: close #1363
Issue Number: close #1369

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

Cause of the problem:
It is caused by writing back the field value when inserting the primary key and the problem of the assignment interface used.
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 8, 2023
@konghaiya konghaiya self-assigned this Mar 8, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.3 milestone Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.02 ⚠️

Comparison is base (d66a3ca) 43.11% compared to head (6c8bb44) 43.10%.

❗ Current head 6c8bb44 differs from pull request most recent head 2be7022. Consider uploading reports for the commit 2be7022 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1370      +/-   ##
===================================================
- Coverage            43.11%   43.10%   -0.02%     
===================================================
  Files                 1836     1836              
  Lines               397197   397196       -1     
===================================================
- Hits                171261   171218      -43     
- Misses              225936   225978      +42     
Impacted Files Coverage Δ
storage/tianmu/core/tianmu_table.cpp 46.15% <66.66%> (-0.16%) ⬇️
storage/innobase/include/dict0stats_bg.ic 50.00% <0.00%> (-50.00%) ⬇️
strings/str2int.c 72.72% <0.00%> (-6.07%) ⬇️
storage/innobase/buf/buf0block_hint.cc 88.23% <0.00%> (-5.89%) ⬇️
storage/innobase/mach/mach0data.cc 83.78% <0.00%> (-5.41%) ⬇️
storage/innobase/row/row0vers.cc 71.66% <0.00%> (-4.00%) ⬇️
storage/tianmu/core/pack_str.h 88.37% <0.00%> (-2.33%) ⬇️
storage/innobase/dict/dict0stats_bg.cc 91.48% <0.00%> (-2.13%) ⬇️
sql/field.cc 57.40% <0.00%> (-1.20%) ⬇️
storage/innobase/buf/buf0flu.cc 85.35% <0.00%> (-0.43%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit e8f0794 into stoneatom:stonedb-5.7-dev Mar 8, 2023
@konghaiya konghaiya deleted the dev_lhj_1363 branch March 27, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
3 participants