Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu):The delta layer supports master-slave synchronization(#1381) #1382

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Mar 10, 2023

Summary about this PR

Issue Number: close #1381

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Mar 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Mar 10, 2023
Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 77.77% and project coverage change: +43.10 🎉

Comparison is base (25eff02) 0.00% compared to head (05e3b0e) 43.10%.

❗ Current head 05e3b0e differs from pull request most recent head 1cee18b. Consider uploading reports for the commit 1cee18b to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           stonedb-5.7-dev    #1382       +/-   ##
====================================================
+ Coverage                 0   43.10%   +43.10%     
====================================================
  Files                    0     1836     +1836     
  Lines                    0   397194   +397194     
====================================================
+ Hits                     0   171219   +171219     
- Misses                   0   225975   +225975     
Impacted Files Coverage Δ
storage/tianmu/core/tianmu_table.h 82.35% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 49.95% <60.00%> (ø)
storage/tianmu/core/tianmu_table.cpp 46.49% <84.61%> (ø)

... and 1833 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mergify mergify bot merged commit 106431a into stoneatom:stonedb-5.7-dev Mar 10, 2023
@Nliver Nliver added this to the StoneDB_5.7_v1.0.3 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

feature: The delta layer supports master-slave synchronization
4 participants