Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu):set sql_mode=NO_KEY_ERROR,Cannot create stored routine xxx. Check warnings(#1388) #1392

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

konghaiya
Copy link
Collaborator

@konghaiya konghaiya commented Mar 15, 2023

NOTE: When adding new SQL_MODE types, make sure to also add them to
the scripts used for creating the MySQL system tables in
scripts/mysql_system_tables.sql and scripts/mysql_system_tables_fix.sql

Summary about this PR

Issue Number: close #1388

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 15, 2023
@konghaiya konghaiya self-assigned this Mar 15, 2023
@konghaiya konghaiya added this to the stonedb_5.7_v1.0.3 milestone Mar 15, 2023
@mergify mergify bot merged commit 2502ca5 into stoneatom:stonedb-5.7-dev Mar 17, 2023
…x. Check warnings(stoneatom#1388)

NOTE: When adding new SQL_MODE types, make sure to also add them to
the scripts used for creating the MySQL system tables
in scripts/mysql_system_tables.sql and scripts/mysql_system_tables_fix.sql
@konghaiya konghaiya deleted the bev_lhj_1388 branch March 27, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Development

Successfully merging this pull request may close these issues.

bug: Stored procedures cannot be created if the value of sql_mode includes variable no_key_error.
3 participants