Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix mysqld crash when exec query limit 0 (#1394) #1395

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(tianmu): fix mysqld crash when exec query limit 0 (#1394) #1395

merged 1 commit into from
Mar 17, 2023

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Mar 15, 2023

Cause: tianmu engine cannot process this scenario when limit=0 and cannot get conds, resulting in crash
Solution: limit 0 is executed without tianmu

Summary about this PR

Issue Number: close #1394

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

This pull request's title should follow requirements next. @adofsauron please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Mar 15, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@adofsauron adofsauron changed the title fix(tianmu): mysqld crash when exec query limit 0 (#1394) fix(tianmu): fix mysqld crash when exec query limit 0 (#1394) Mar 15, 2023
RingsC
RingsC previously requested changes Mar 15, 2023
mysql-test/suite/tianmu/t/issue1394.test Show resolved Hide resolved
@adofsauron adofsauron requested a review from konghaiya March 17, 2023 01:46
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

    Cause: tianmu engine cannot process this scenario when limit=0 and cannot get conds, resulting in crash
    Solution: limit 0 is executed without tianmu
@mergify mergify bot merged commit e2b836a into stoneatom:stonedb-5.7-dev Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: mysqld crash when exec query like "select * from a limit 0"
5 participants