Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tianmu): fix crash when the aggregated element was decimal (#1402) #1482

Closed
wants to merge 3 commits into from
Closed

Conversation

adofsauron
Copy link
Collaborator

@adofsauron adofsauron commented Mar 28, 2023

1. Fix the crash first
2. then redesign the entire aggregated data stream

Summary about this PR

Issue Number: close #1402

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

…primary/secondary synchronization if UUIDs are used as the primary key(#1464)

Cause of the problem:
When performing a primary key scan under the master slave, "ha_tianmu:: position()" is called first to obtain the primary key value from the "record",
However, in this scenario, after calling the "key_copy()" function, the "record" will be cleared, resulting in the subsequent "GetKeys()" obtaining a null primary key value.
Solution:
Because the value "handler->ref" is not used in the future, you can simply delete the call to "key_copy()".
@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-bug bug for pull request label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (ef58f6c) 42.86% compared to head (0fe2904) 42.94%.

❗ Current head 0fe2904 differs from pull request most recent head 29139ec. Consider uploading reports for the commit 29139ec to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           stonedb-5.7-dev    #1482      +/-   ##
===================================================
+ Coverage            42.86%   42.94%   +0.07%     
===================================================
  Files                 1838     1838              
  Lines               397379   397381       +2     
===================================================
+ Hits                170355   170656     +301     
+ Misses              227024   226725     -299     
Impacted Files Coverage Δ
sql/item.h 41.18% <ø> (+0.06%) ⬆️
storage/tianmu/core/item_tianmu_field.h 64.86% <ø> (ø)
storage/tianmu/core/pack_guardian.cpp 42.75% <ø> (ø)
storage/tianmu/handler/ha_tianmu.cpp 50.04% <ø> (+0.14%) ⬆️
storage/tianmu/core/aggregation_algorithm.cpp 56.27% <100.00%> (+0.31%) ⬆️
storage/tianmu/core/item_tianmu_field.cpp 90.47% <100.00%> (+0.20%) ⬆️

... and 60 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nliver Nliver requested review from RingsC and wisehead March 28, 2023 15:21
@Nliver Nliver added this to the stonedb_5.7_v1.0.4 milestone Mar 28, 2023
@adofsauron adofsauron changed the title fix(tianmu): fix crash when the aggregated element was decimal (#1476) fix(tianmu): fix crash when the aggregated element was decimal (#1402) Mar 29, 2023
@adofsauron adofsauron requested a review from wisehead March 29, 2023 03:18
@@ -134,15 +134,4 @@ student_score CREATE TABLE `student_score` (
DROP DATABASE issue1325_test;
include/sync_slave_sql_with_master.inc
# on slave:
show databases;
Database
information_schema
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does your submitted record carry code submitted by others

@adofsauron adofsauron closed this by deleting the head repository Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-bug bug for pull request
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

bug: Multithread aggregation occur crash when has decimal
5 participants