-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tianmu): fix crash when the aggregated element was decimal (#1402) #1482
Conversation
…primary/secondary synchronization if UUIDs are used as the primary key(#1464) Cause of the problem: When performing a primary key scan under the master slave, "ha_tianmu:: position()" is called first to obtain the primary key value from the "record", However, in this scenario, after calling the "key_copy()" function, the "record" will be cleared, resulting in the subsequent "GetKeys()" obtaining a null primary key value. Solution: Because the value "handler->ref" is not used in the future, you can simply delete the call to "key_copy()".
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## stonedb-5.7-dev #1482 +/- ##
===================================================
+ Coverage 42.86% 42.94% +0.07%
===================================================
Files 1838 1838
Lines 397379 397381 +2
===================================================
+ Hits 170355 170656 +301
+ Misses 227024 226725 -299
... and 60 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…0230323 into stonedb-5.7-dev
@@ -134,15 +134,4 @@ student_score CREATE TABLE `student_score` ( | |||
DROP DATABASE issue1325_test; | |||
include/sync_slave_sql_with_master.inc | |||
# on slave: | |||
show databases; | |||
Database | |||
information_schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does your submitted record carry code submitted by others
Summary about this PR
Issue Number: close #1402
Tests Check List
Changelog
Documentation