Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu): mv func from public to protected(#1501) #1515

Closed

Conversation

zzzz-vincent
Copy link
Contributor

Summary about this PR

Issue Number: close #1501

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zzzz-vincent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Apr 3, 2023
@Nliver Nliver requested review from RingsC, wisehead and hustjieke April 3, 2023 05:43
@Nliver
Copy link
Collaborator

Nliver commented Apr 3, 2023

You are welcome to contribute to StoneDB. Please sign the CLA file. Note that your git configuration email must be the same as your Github account binding email.

@zzzz-vincent
Copy link
Contributor Author

You are welcome to contribute to StoneDB. Please sign the CLA file. Note that your git configuration email must be the same as your Github account binding email.

Added and re push. But it seems that this check is based on previous commits. And I am not sure if it is still possible to change that.

@hustjieke
Copy link
Collaborator

You are welcome to contribute to StoneDB. Please sign the CLA file. Note that your git configuration email must be the same as your Github account binding email.

Added and re push. But it seems that this check is based on previous commits. And I am not sure if it is still possible to change that.

After signed CLA, wait for a while,there will be some delay.

@Nliver
Copy link
Collaborator

Nliver commented Apr 3, 2023

You are welcome to contribute to StoneDB. Please sign the CLA file. Note that your git configuration email must be the same as your Github account binding email.

Added and re push. But it seems that this check is based on previous commits. And I am not sure if it is still possible to change that.

If it doesn't work for a long time, I actually recommend shutting down the PR and resubmitting it

@Nliver
Copy link
Collaborator

Nliver commented Apr 4, 2023

Well, it looks like your CLA process is stuck. I suggest you close this PR. @zzzz-vincent

Then do the following:

  1. Check all of your local Git commit email addresses;
  2. Confirm whether this email address is the same as your Github binding email address;
  3. If they are inconsistent, it is recommended that you modify them to be consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: mv function from public to protected
4 participants