Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport support alter rename t1 to t2 issue1673 #1767

Merged
merged 5 commits into from
May 16, 2023
Merged

Backport support alter rename t1 to t2 issue1673 #1767

merged 5 commits into from
May 16, 2023

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented May 10, 2023 •
edited
Loading

Summary about this PR

Issue Number: close #1673

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

hustjieke added 3 commits May 10, 2023 15:34
@hustjieke
feat(tianmu): support the ALTER syntax, ALTER table t1 rename t2, add …
57e0848 
[summary]
1. add/fix mtr for alter table
2. support alter table: mix add/drop column、order column and other syntaxs to use
@hustjieke
fix(tianmu):fix alter table add/drop primary key.(stoneatom#1673)
92876bb 
in some cases, can insert same values by primary key after atler table add
primary key.
@hustjieke
feat(tianmu): complete alter syntax stoneatom#1673
cf53488 
[summary]
1. support alter table rename t1 t2
2. support alter add/drop primary key
@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

This pull request's title should follow requirements next. @hustjieke please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • perf: Changes to improve code performance
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented May 10, 2023

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

Double0101
Double0101 approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@Double0101 Double0101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

konghaiya
konghaiya approved these changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@konghaiya konghaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d376a14 into stoneatom:stonedb-8.0-dev May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konghaiya konghaiya konghaiya approved these changes

@Double0101 Double0101 Double0101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hustjieke @Double0101 @konghaiya