Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tianmu): stonedb namespace to tianmu #337

Merged

Conversation

hustjieke
Copy link
Collaborator

@hustjieke hustjieke commented Aug 1, 2022

[summary]

  1. Change all engine stonedb to tianmu
  2. Change SDB to tianmu
  3. Also include mysql-test
  4. Change file magic number to TianmuTB

Issue Number: close #334

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

This pull request's title is not fulfill the requirements. @hustjieke please update it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Aug 1, 2022
@hustjieke hustjieke force-pushed the feat_change_engine_name_to_tianmu branch 2 times, most recently from fa64563 to 566cb9d Compare August 1, 2022 13:20
@hustjieke hustjieke force-pushed the feat_change_engine_name_to_tianmu branch from 566cb9d to 29b9d8a Compare August 1, 2022 23:47
@hustjieke hustjieke marked this pull request as ready for review August 2, 2022 01:22
Copy link
Collaborator

@isredstar isredstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke hustjieke requested a review from adofsauron August 2, 2022 12:07
Copy link
Collaborator

@adofsauron adofsauron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hustjieke hustjieke merged commit eed32f6 into stoneatom:stonedb-5.7 Aug 3, 2022
xiaoguangye added a commit to xiaoguangye/stonedb that referenced this pull request Aug 5, 2022
# This is the 1st commit message:

rich doc to fix  env dependence "not found" (stoneatom#316)


# This is the commit message #2:

fix(mtr): make the mtr passed (stoneatom#315) (stoneatom#317)

[summary]
How to run:
./mysql-test-run.pl --suite=stonedb --nowarnings --force --nocheck-testcases

1. test cases below are failed, we ignored them first:
issue410
issue415
issue433
issue446
issue515
load.test
2. Sys variables next are not set correctly, they should be added to `/mysql-test/include/default_mysqld.cnf`.
stonedb_insert_delayed = 0
stonedb_ini_allowmysqlquerypath=1

3.check-testcases: A new MTR option to enforce strict cleanup:
https://dev.mysql.com/blog-archive/fail-check-testcases-a-new-mtr-option-to-enforce-strict-cleanup

In `mtr` comment:
```
Some options that control enabling a feature for normal test runs,
can be turned off by prepending 'no' to the option, e.g. --notimer.
This applies to reorder, timer, check-testcases and warnings.
```
Currently we turn off it first to make mtr run success.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #3:

feat(stonedb): update the copyright date time (stoneatom#321) (stoneatom#324)


# This is the commit message #4:

fix(core): fix crash when executing sql. (stoneatom#327) (stoneatom#328)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #5:

feat(index): Unified class member variable name with google style (stoneatom#311) (stoneatom#312)

[summary]
Class member name will be like:

class TableInfo {
  ...
 private:
  std::string table_name_;  // OK - underscore at end.
  static Pool<TableInfo>* pool_;  // OK.
};

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #6:

fix(mtr):move character_set to test.character_set, fix main mtr_test and innodb mtr_test(stoneatom#277) (stoneatom#335)

* fix(mtr):fix innodb mtr and mv some test to test/innodb

* fix(mtr):move character_set to test/main/

fix(mtr):mv main mtr character_set test to test/main/cahracter_set

fix(mtr):mv myisam error mtr-test to test/main/myisam

fix(mtr):add optimizer_switch to include/default_mysqld.cnf

* fix(mtr):fix main mtr optimizer_switch amd mv some test to test/main

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
# This is the commit message #7:

feat(tianmu): stonedb namespace to tianmu (stoneatom#337)

[summary]
1. Change all engine stonedb to tianmu
2. Change SDB to tianmu
3. Also include mysql-test
4. Change file magic number to TianmuTB
# This is the commit message stoneatom#8:

fix bugs of stoneatom#309 and stoneatom#310 (stoneatom#313)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
xiaoguangye pushed a commit to xiaoguangye/stonedb that referenced this pull request Aug 11, 2022
[summary]
1. Change all engine stonedb to tianmu
2. Change SDB to tianmu
3. Also include mysql-test
4. Change file magic number to TianmuTB
@Nliver Nliver added this to the StoneDB_5.7_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-feature feature for pull request
Projects
Development

Successfully merging this pull request may close these issues.

feature: change engine name to tianmu
6 participants