Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(execution): improve code readability (#535) #537

Merged
merged 1 commit into from
Sep 22, 2022
Merged

style(execution): improve code readability (#535) #537

merged 1 commit into from
Sep 22, 2022

Conversation

taofengliu
Copy link
Contributor

@taofengliu taofengliu commented Sep 22, 2022

Summary about this PR

Issue Number: close #535

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2022

CLA assistant check
All committers have signed the CLA.

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

This pull request's title should follow requirements next. @taofengliu please check it 👇.

Valid format:

fix(vc): fix sth..... (#3306)
  ^         ^---------^  ^----^
  |         |            |
  |         +            +-> you issue id.
  |         |
  |         +-> Summary in present tense.
  |
  +-------> Type: feat, fix, docs, workflow, style, refactor, test, website, chore

Valid types:

  • feat: new feature for stonedb
  • fix: bug fix for stonedb
  • docs: changes to the documentation
  • workflow: ci/cd in .github
  • refactor: refactoring production code, eg. renaming a variable
  • style: formatting, missing semi colons, etc; no production code change
  • test: adding missing tests, refactoring tests; no production code change
  • website
  • chore: updating grunt tasks etc; no production code change

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@taofengliu taofengliu changed the title Improve code readability (#535) style(execution): improve code readability (#535) Sep 22, 2022
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

storage/tianmu/core/query.cpp Show resolved Hide resolved
@taofengliu
Copy link
Contributor Author

There is 1 workflow awaiting approval now.

Copy link
Collaborator

@hustjieke hustjieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit db45bef into stoneatom:stonedb-5.7-dev Sep 22, 2022
@taofengliu taofengliu deleted the issue_#535 branch October 9, 2022 11:59
@Nliver Nliver added this to the StoneDB_5.7_v1.0.1 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

feature: improve code readability of Query::Preexecute in storage/tianmu/core/query.cpp
5 participants