Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stonedb8.0): mysql load sql with set clause should report warning. (#551) #552

Merged
merged 2 commits into from
Sep 24, 2022
Merged

feat(stonedb8.0): mysql load sql with set clause should report warning. (#551) #552

merged 2 commits into from
Sep 24, 2022

Conversation

lujiashun
Copy link

@lujiashun lujiashun commented Sep 22, 2022 •
edited
Loading

Summary about this PR

Issue Number: close #551
warns when execute the sql as below:
LOAD DATA INFILE '/data/1.txt' Into TABLE tmp_loaddata2 FIELDS TERMINATED BY ','(id,name) set id2 =3 ;

Tests Check List

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Changelog

  • New Feature
  • Bug Fix
  • Improvement
  • Performance Improvement
  • Build/Testing/CI/CD
  • Documentation
  • Not for changelog (changelog entry is not required)

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features

@mergify
Copy link
Contributor

mergify bot commented Sep 22, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the PR-feature feature for pull request label Sep 22, 2022
@lujiashun lujiashun changed the base branch from stonedb-5.7-dev to stonedb-8.0-dev September 22, 2022 12:13
@lujiashun lujiashun self-assigned this Sep 22, 2022
RingsC
RingsC reviewed Sep 23, 2022
View reviewed changes
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
storage/tianmu/core/engine.cpp Outdated Show resolved Hide resolved
RingsC
RingsC approved these changes Sep 24, 2022
View reviewed changes
Copy link
Contributor

@RingsC RingsC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andyli029
andyli029 approved these changes Sep 24, 2022
View reviewed changes
Copy link
Contributor

@andyli029 andyli029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mergify mergify bot merged commit 90c926a into stoneatom:stonedb-8.0-dev Sep 24, 2022
@lujiashun lujiashun deleted the feat-551 branch September 29, 2022 11:23
@Nliver Nliver added this to the StoneDB_8.0_v1.0.0 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyli029 andyli029 andyli029 approved these changes

@RingsC RingsC RingsC approved these changes

@DandreChen DandreChen Awaiting requested review from DandreChen

@hustjieke hustjieke Awaiting requested review from hustjieke

@isredstar isredstar Awaiting requested review from isredstar

Assignees

@lujiashun lujiashun

Labels
PR-feature feature for pull request
Projects
StoneDB for MySQL 8.0
Status: Done
Milestone
StoneDB_8.0_v1.0.0
Development

Successfully merging this pull request may close these issues.

feature(stonedb): mysql load sql with set clause should report warning
4 participants
@lujiashun @RingsC @andyli029 @Nliver